Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I always figured the unwritten rule for every developer is to always follow the existing code's style regardless of their own opinion of it.


That's not always the case, and sometimes if you don't know the language very well - in my case, Ruby - then certain patterns aren't available to you and it looks hokey without you realizing it.


Completely forgivable. This pull request[0], on the other hand, is probably more along the lines of what mirsadm was thinking of.

[0]: https://github.com/Aaronius/Stupid-Table-Plugin/commit/fbf3d...


That's the douchiest diff I've seen yet. I've seen diffs where a shitty and misconfigured IDE had reformatted half the code and the guy hadn't reviewed his diff, but "incidentally spaces to tab" is the biggest "fuck you reviewer" I can think of.



I have no clue where that commit is coming from. How do I get to it? Thanks.


It's the same commit you linked to, but ignoring whitespace changes (&w=1, like diff -w).


Apparently the parameter w=1 fixes the white space for the diff in the browser. Is there a way to make the pull request reference that?




Consider applying for YC's Fall 2026 batch! Applications are open till July 27.

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: